Pymongo retry wrapper with tenacity #2045
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n MongoDB restarts without crashing requests.
- Add support for additional retryable exceptions (NotPrimaryError, CursorNotFound, etc.) - Implement smart OperationFailure handling by error code and labels - Add comprehensive tests for retryable error scenarios - Maintain backward compatibility with existing functionality
- Remove redundant hasattr(exception, "details") duplicate - Clean up function logic for better readability
- Create RETRYABLE_ERROR_CODES constant for shared use - Remove duplicate retryable_codes definitions - Improve maintainability and readability
- Add comprehensive list of retryable OperationFailure error codes - Include additional codes like StaleShardVersion (63), StaleEpoch (150), StaleConfig (13388) - Add ExceededTimeLimit (262) and RetryChangeStream (234) codes - Update tests to include new retryable error codes
- Focus on error codes relevant to single-node DigitalOcean MongoDB - Remove replica set specific codes (10107, 11600, 11602, 13435, 13436, 63, 150, 13388, 234) - Keep network/connection related codes: 6, 7, 89, 91, 9001, 262, 64 - Include 189 (PrimarySteppedDown) for broader compatibility - Update tests accordingly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement retry db wrapper to let server “ride out” brief one node only DigitalOcean MongoDB restarts without crashing requests.