Make --allow-packet-socket-write a public flag. #12339
Merged
+24
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
copybara-service
bot
force-pushed
the
test/cl838942720
branch
13 times, most recently
from
90882cd to
a12de4a
Compare
This flag is now required for Docker versions 28 and beyond to function inside gVisor, as dockerd sends unsolicited ARP/NA requests using AF_PACKET sockets. The flag is no longer test-only. The docker behavior to send the ARP/NA pkts was introduced in eaa84bc [1]. Failure to send was made a hard error in 422e056 [2], and in bc130f36 [3], docker evolved to rely on these packets being sent. [1] moby/moby@eaa84bc8f4 [2] moby/moby@422e056b0f [3] moby/moby@bc130f367d PiperOrigin-RevId: 840805091
copybara-service
bot
force-pushed
the
test/cl838942720
branch
from
a12de4a to
9d75d56
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make --allow-packet-socket-write a public flag.
This flag is now required for Docker versions 28 and beyond to function
inside gVisor, as dockerd sends unsolicited ARP/NA requests using AF_PACKET
sockets. The flag is no longer test-only.
The docker behavior to send the ARP/NA pkts was introduced in eaa84bc [1].
Failure to send was made a hard error in 422e056 [2], and in bc130f36 [3],
docker evolved to rely on these packets being sent.
[1] moby/moby@eaa84bc8f4
[2] moby/moby@422e056b0f
[3] moby/moby@bc130f367d