Skip to content

Conversation

@frenck
Copy link
Member

@frenck frenck commented Nov 22, 2025

Proposed Changes

The Home Assistant project has deprecated support for the armv7 architecture; fully dropping support for it in the upcoming Home Assistant 2025.12 release. This PR removes it from this add-on.

../Frenck

Summary by CodeRabbit

  • Chores
    • Narrowed supported processor architectures to aarch64 and amd64 only; armhf, armv7, and i386 are no longer supported.
    • Updated documentation and build configuration to reflect current architecture support.

✏️ Tip: You can customize this high-level summary in your review settings.

@frenck frenck added the breaking-change A breaking change for existing users. label Nov 22, 2025
@coderabbitai
Copy link

coderabbitai bot commented Nov 22, 2025

Walkthrough

This pull request discontinues support for armhf, armv7, and i386 architectures across the project. Changes include narrowing the Renovate configuration regex to only match aarch64 and amd64, removing architecture-specific build configurations, updating runtime configuration to exclude armv7, and removing associated documentation badges.

Changes

Cohort / File(s) Summary
Build & Runtime Configuration
grocy/build.yaml, grocy/config.yaml
Removed armv7 architecture entries from build mappings and architecture list configuration.
CI/CD Configuration
.github/renovate.json
Narrowed Renovate regex matchStrings from (aarch64|amd64|armhf|armv7|i386) to (aarch64|amd64) only for Dockerfile update matching.
Documentation
README.md
Removed badges for armhf, armv7, i386, alpine-packages, dockerhub, and python-packages.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

  • Context: All changes follow a consistent, straightforward pattern of removing architecture references across configuration and documentation files.
  • Areas for attention: Verify that removing these architectures doesn't break any undocumented dependencies or CI pipelines that may still reference them.

Poem

🐰 Hop! We've trimmed the architectures lean,
Keeping only the strongest seen,
aarch64, amd64 stand tall,
Cleaner configs, badges removed from all! 🏗️

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely summarizes the main change across all modified files: dropping armv7 support from the add-on.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch frenck-2025-0555

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 981bbb6 and 145b0ac.

📒 Files selected for processing (4)
  • .github/renovate.json (1 hunks)
  • README.md (0 hunks)
  • grocy/build.yaml (0 hunks)
  • grocy/config.yaml (0 hunks)
💤 Files with no reviewable changes (3)
  • grocy/config.yaml
  • README.md
  • grocy/build.yaml
🔇 Additional comments (1)
.github/renovate.json (1)

15-15: ✓ Correct architecture restriction for Renovate dependency tracking.

The regex pattern now properly restricts dependency version detection to only supported architectures (aarch64 and amd64), preventing Renovate from attempting to update dependencies for dropped architectures. The pattern syntax is valid and aligns with the PR objective.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@frenck frenck merged commit f4a37d4 into main Nov 22, 2025
20 checks passed
@frenck frenck deleted the frenck-2025-0555 branch November 22, 2025 18:58
@github-actions github-actions bot locked and limited conversation to collaborators Nov 24, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

breaking-change A breaking change for existing users.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants