Skip to content

fix: notifications to respect add to cart config #3229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jef merged 4 commits into from
Apr 24, 2025
Merged

fix: notifications to respect add to cart config #3229

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
276786c
Fixed notifications to respect add to cart config with twilio and pus…
CardenB Mar 11, 2025
2702d97
Update pushover.ts
jef Mar 16, 2025
50593ee
Merge branch 'main' into carden/fix_notifs
jef Apr 24, 2025
53f8211
style: linting
jef Apr 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/messaging/pushover.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,8 @@
const message: PushoverMessage =
pushover.priority < 2
? {
message: link.cartUrl ? link.cartUrl : link.url,
message:
link.cartUrl && config.store.autoAddToCart ? link.cartUrl : link.url,

Check failure on line 21 in src/messaging/pushover.ts

View workflow job for this annotation

GitHub Actions / Build and lint 

Replace `·?·link.cartUrl` with `⏎················?·link.cartUrl⏎···············`
priority: pushover.priority,
sound: pushover.sound,
title: Print.inStock(link, store),
Expand All @@ -26,7 +27,8 @@
}
: {
expire: pushover.expire,
message: link.cartUrl ? link.cartUrl : link.url,
message:
link.cartUrl && config.store.autoAddToCart ? link.cartUrl : link.url,

Check failure on line 31 in src/messaging/pushover.ts

View workflow job for this annotation

GitHub Actions / Build and lint 

Replace `··?·link.cartUrl` with `⏎················?·link.cartUrl⏎···············`
priority: pushover.priority,
sound: pushover.sound,
retry: pushover.retry,
Expand Down
3 changes: 2 additions & 1 deletion src/messaging/twilio.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,8 @@ export function sendTwilioMessage(link: Link, store: Store) {
logger.debug('↗ sending twilio message');

(async () => {
const givenUrl = link.cartUrl ? link.cartUrl : link.url;
const givenUrl =
link.cartUrl && config.store.autoAddToCart ? link.cartUrl : link.url;
const message = `${Print.inStock(link, store)}\n${givenUrl}`;
const numbers = twilio.to.split(',');
const results = [];
Expand Down
Loading