Skip to content

[Improve code readability] Replace the two boolean variables that control the visibility of security warnings with a single boolean variable (#537) #549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
jiakuanghe wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[Improve code readability] Replace the two boolean variables that control the visibility of security warnings with a single boolean variable (#537) #549

jiakuanghe wants to merge 2 commits into from

Conversation

@jiakuanghe
Copy link
Contributor

@jiakuanghe jiakuanghe commented Mar 18, 2023

Fixes #537

[Improve code readability] Replace the two boolean variables that control the visibility of security warnings with a single boolean variable (#537)

  • Delete the old internal variable showWarnings and its existing getter read the negated value of the new variable hideWarnings.
  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@samho2008
[Improve code readability] Replace the two boolean variables that con…
3aab27c 
…trol the visibility of security warnings with a single boolean variable (jenkinsci#537)

- Delete the old internal variable `showWarnings` and its existing getter read the negated value of the new variable `hideWarnings`.
@jiakuanghe jiakuanghe mentioned this pull request Mar 18, 2023
Merged
6 tasks
freyam
freyam approved these changes Mar 20, 2023
View reviewed changes
Copy link

@freyam freyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Great work @jiakuanghe 🚀

julien-demaziere
julien-demaziere approved these changes Apr 17, 2023
View reviewed changes
Copy link

@julien-demaziere julien-demaziere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@freyam freyam freyam approved these changes

@julien-demaziere julien-demaziere julien-demaziere approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jiakuanghe @freyam @julien-demaziere @samho2008