Skip to content

Conversation

@Ciioer
Copy link

@Ciioer Ciioer commented Dec 1, 2022

  • All tests passed. If this feature is not already covered by the tests, I added new tests.

I have read the CLA Document and I hereby sign the CLA

@Ciioer
Copy link
Author

Ciioer commented Dec 1, 2022

This PR is the successor of PR#35.Thanks for your reply.According to your request, I modified the code.
1.Modify the import method of ProjectDependenciesResolver,adjusted from @inject to @Component(role=ProjectDependenciesResolver.class).The reason for using inject before is that when I use idea2022.1 and maven is 3.2.1, using @ Component will report an error No implementation for xxx was bound. Now I've changed it
2.I simplified the code of getDependencyNode and remove negate
3.Add javadoc for my code
4.I adjusted the unit test code,and I test my code by remote debugging project artifactory-maven-plugin-example.The buildinfo.txt is the json of buildinfo.I get it from BuildInfoRecorder#sessionEnded
buildInfo.txt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant