fix: deal with optional variables when undefined #451
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If these values are not provided, this task will fail as the variables are missing and are not defined in a task beforehand. Signed-off-by: Patrick Hasler <[email protected]>
Task will fail if no k3s_version is provided. But I'm actually not sure if this will even work, as `default(omit)` will set `INSTALL_K3S_VERSION` to an empty string. Signed-off-by: Patrick Hasler <[email protected]>
Use `create:` parameter of `ansible.builtin.lineinfile` to create file when it's missing. Otherwise the task will fail if file does not exist, which breaks the fetch token mechanism. Signed-off-by: Patrick Hasler <[email protected]>
adf-patrickha
force-pushed
the
fix/undefined_variables
branch
from
e55f369 to
80a132f
Compare
Author
|
Ping @dereknola for review (Cannot assign it on my own apparently). |
dereknola
requested changes
Oct 15, 2025
Member
dereknola
left a comment
dereknola
left a comment
There was a problem hiding this comment.
There should never NOT be a k3s.service.env. This is the 4 or 5th attempt by people trying to fix something that is not broken. As pointed out in:
#424
#425
#368
The k3s install script is responsible for creating those files. If the file is missing, then something has gone wrong with your installation.
The README is not intended to be a complete guide. The k3s_version variable is not optional, and that is laid out in the inventory sample
Finally, the opt_tls_san is defined as a blank string, so its inclusion is not a problem generally.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently both k3s_server and k3s_agent roles will fail when you follow the instructions from the README, as some tasks are dependent on optional variables that might not be set.
Changes
k3s_version: Usedefault(omit)when no version is specifiedopts_tls_sanandextra_server_argsoptionalk3s.service.envfile when settingK3S_TOKEN, if the file is missing at that point