fix: state: last to use value from last Graph coordinate #1308
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
state: lastbreaks rendering with bar charts (#1248) becausepointsare not calculated for bar charts.This fix accesses the value of the last coordinate from the
Graphinstead, which is exactly what I want to have displayed when using this option.To my understanding (and testing), using the last
coordis a simpler and more reliable fix than always calculatingpoints(ref #1075), because the lastpointfor a grouped bar chart is not the value of the last coordinate (the lastpointis actually the average of the last two states, so a completely different value). (Surprisingly, the same is true for grouped line graphs, where the point is selectable and shows this incorrect value as the hover state, but that may be a different issue.)