Skip to content

Conversation

@Ninja3047
Copy link

The previous fix #274 only updated the address for target specific directives. There are a number of generic directives that also emit bytes so the address needs to be updated.

The ppc regression test should have caught this but the expected value was incorrect.
The expected branch target for the PPC test is off by 8 and has been updated from

0x00000000   4                 38800001  li r4, 1
0x00000004   4                 38840001  addi r4, r4, 1
0x00000008   4                 4800bff9  bl 0xc000
0x0000000c   4                 38800001  li r4, 1
0x00000010   4                 38a50001  addi r5, r5, 1
0x00000014   4                 4800bff9  bl 0xc00c

to

0x00000000   4                 38800001  li r4, 1
0x00000004   4                 38840001  addi r4, r4, 1
0x00000008   4                 4800bff9  bl 0xc000
0x0000000c   4                 38800001  li r4, 1
0x00000010   4                 38a50001  addi r5, r5, 1
0x00000014   4                 4800bff5  bl 0xc008

petabyt added a commit to petabyt/keystone2 that referenced this pull request Jul 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant