Fix: Optional field regex validation in MsgspecDTO (#4195) #4509
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem
When a field is marked as
Optional[Annotated[str, msgspec.Meta(pattern=...)]], the regex constraint validation was bypassed, allowing invalid input to pass through.Before:
After:
Solution
Added post-decoding validation that:
Metaconstraints fromOptional[Annotated[T, Meta(...)]]typesValidationExceptionfor invalid patternsChanges
Modified
msgspec_dto.py:_extract_meta_from_annotation()to unwrap Optional/Annotated typesdecode_builtins()anddecode_bytes()to add validation_validate_meta_constraints()and_validate_instance()methodsAdded comprehensive tests in
test_dto_optional_validation.py:Testing
Closes