-
Notifications
You must be signed in to change notification settings - Fork 352
Development: Migrate courses documentation
#11767
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Development: Migrate courses documentation
#11767
Conversation
WalkthroughDocumentation reorganization migrates course customization content from legacy RST format to new MDX pages for instructor and student audiences. Sidebar configurations updated to include the new course documentation entries. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Nitpick comments (1)
documentation/docs/student/courses.mdx (1)
1-5: Align doc title with top-level heading for consistency.Frontmatter sets
title: Courseswhile the content starts with# Customizing Courses. This will typically show “Courses” as the page title and then immediately another H1 “Customizing Courses”, which can feel redundant and inconsistent.Consider either:
- Renaming the frontmatter title to “Customizing Courses”, or
- Keeping
title: Coursesand demoting the in-content heading to## Customizing Courses.Also applies to: 14-17
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (16)
docs/user/courses/customizable/buttons/course_settings_button.pngis excluded by!**/*.png,!**/*.pngdocs/user/courses/customizable/course_management.pngis excluded by!**/*.png,!**/*.pngdocumentation/docs/instructor/assets/courses/course_create.pngis excluded by!**/*.png,!**/*.pngdocumentation/docs/instructor/assets/courses/course_delete.pngis excluded by!**/*.png,!**/*.pngdocumentation/docs/instructor/assets/courses/course_edit.pngis excluded by!**/*.png,!**/*.pngdocumentation/docs/instructor/assets/courses/course_header.pngis excluded by!**/*.png,!**/*.pngdocumentation/docs/instructor/assets/courses/course_management.pngis excluded by!**/*.png,!**/*.pngdocumentation/docs/instructor/assets/courses/course_management_button.pngis excluded by!**/*.png,!**/*.pngdocumentation/docs/instructor/assets/courses/course_overview.pngis excluded by!**/*.png,!**/*.pngdocumentation/docs/instructor/assets/courses/course_overview_button.pngis excluded by!**/*.png,!**/*.pngdocumentation/docs/instructor/assets/courses/course_settings.pngis excluded by!**/*.png,!**/*.pngdocumentation/docs/student/assets/courses/course_header.pngis excluded by!**/*.png,!**/*.pngdocumentation/docs/student/assets/courses/course_overview.pngis excluded by!**/*.png,!**/*.pngdocumentation/docs/student/assets/courses/course_overview_button.pngis excluded by!**/*.png,!**/*.pngdocumentation/docs/student/assets/courses/course_register.pngis excluded by!**/*.png,!**/*.pngdocumentation/package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (5)
docs/user/courses/customizable.rst(1 hunks)documentation/docs/instructor/courses.mdx(1 hunks)documentation/docs/student/courses.mdx(1 hunks)documentation/sidebar-instructors.ts(1 hunks)documentation/sidebar-students.ts(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (10)
- GitHub Check: Codacy Static Code Analysis
- GitHub Check: Build and Push Docker Image / Build linux/arm64 Docker Image for ls1intum/artemis
- GitHub Check: Build and Push Docker Image / Build linux/amd64 Docker Image for ls1intum/artemis
- GitHub Check: Build .war artifact
- GitHub Check: client-style
- GitHub Check: server-style
- GitHub Check: client-tests
- GitHub Check: server-tests
- GitHub Check: Analyse
- GitHub Check: Mend Security Check
🔇 Additional comments (4)
documentation/sidebar-instructors.ts (1)
9-9: Addingcoursesto the instructors sidebar aligns with the new doc id.The new
coursesentry correctly matches theid: coursesfrontmatter indocumentation/docs/instructor/courses.mdx, so the link should resolve as expected.documentation/sidebar-students.ts (1)
10-10: Student sidebarcoursesitem is consistent with the new doc id.This entry lines up with
id: coursesindocumentation/docs/student/courses.mdx, so navigation from the student sidebar to the courses page should work fine.docs/user/courses/customizable.rst (2)
6-9: Verify and update the student docs URL (customizing-coursesvscourses).The note links to
.../student/customizing-courses/, but the new MDX documentation uses the idcoursesand PR instructions reference/student/courses. This discrepancy will likely produce a broken link on the published docs.Update the URL to match the actual route (likely
/student/courses/) or configure a redirect/slug to preserve the old path.Example diff if
/student/courses/is correct:- This section has moved to `new student documentation <https://ls1intum.github.io/Artemis/student/customizing-courses/>`_. + This section has moved to `new student documentation <https://ls1intum.github.io/Artemis/student/courses/>`_.
11-14: Verify instructor documentation URL path for correctness.The note points to
https://ls1intum.github.io/Artemis/instructor/customizing-courses/but needs confirmation that this is the canonical path. If the instructor documentation uses/instructor/courses/instead, the URL should be updated accordingly, or a redirect should be created to maintain the old path.If
/instructor/courses/is the correct path, adjust to:- This section has moved to `new instructor documentation <https://ls1intum.github.io/Artemis/instructor/customizing-courses/>`_. + This section has moved to `new instructor documentation <https://ls1intum.github.io/Artemis/instructor/courses/>`_.
End-to-End (E2E) Test Results Summary
|
||||||||||||||||||||||||||||||
LuisL02
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested locally: LGTM



Checklist
General
Motivation and Context
We want to migrate to the new documentation https://ls1intum.github.io/Artemis/ from https://artemis-platform.readthedocs.io/en/latest/index.html to provide a more modern and user friendly access to additional information around Artemis.
Description
Coursessection to the new documentationStudentandInstructordocumentationSteps for Testing
Run
npm installandnpm startin the/documentationfolderReview Progress
Manual Tests
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.