Skip to content

Conversation

@7ender
Copy link

@7ender 7ender commented Dec 1, 2025

What is the purpose of this pull request?

  • New Icon

Description

Added new fishing-hook icon.

Icon use case

Can be used in categories: fishing, sport, hobby

Alternative icon designs

Icon Design Checklist

Concept

  • I have provided valid use cases for each icon.
  • I have not added any a brand or logo icon.
  • I have not used any hate symbols.
  • I have not included any religious or political imagery.

Author, credits & license

  • The icons are solely my own creation.
  • The icons were originally created in # by @
  • I've based them on the following Lucide icons:
  • I've based them on the following design:

Naming

  • I've read and followed the naming conventions
  • I've named icons by what they are rather than their use case.
  • I've provided meta JSON files in icons/[iconName].json.

Design

  • I've read and followed the icon design guidelines
  • I've made sure that the icons look sharp on low DPI displays.
  • I've made sure that the icons look consistent with the icon set in size, optical volume and density.
  • I've made sure that the icons are visually centered.
  • I've correctly optimized all icons to three points of precision.

Before Submitting

@github-actions github-actions bot added 🎨 icon About new icons 🫧 metadata Improved metadata labels Dec 1, 2025
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 ChatGPT Tags suggestions ✨

I've asked ChatGPT for some suggestions for tags.

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2025

Added or changed icons

fishing-hook

Preview cohesion square-user
fishing-hook
volume
Preview stroke widths fishing-hook
fishing-hook
fishing-hook
DPI Preview

16px (shadcn/ui)

fishing-hook

24px (default)

fishing-hook

32px (shadcn/ui + retina)

fishing-hook

48px (default + retina)

fishing-hook
Icon X-rays fishing-hook
Icon Diffs fishing-hook
Icons as code

Works for: lucide-react, lucide-react-native, lucide-preact, lucide-vue-next

const FishingHookIcon = createLucideIcon('FishingHook', [
  ["path",{"d":"m15 14 3-2v4c0 2.8-2.2 5-5 5s-5-2.2-5-5V7"}],
  ["circle",{"cx":"8","cy":"5","r":"2"}]
])

@karsa-mistmere
Copy link
Member

Hey @7ender,

We definitely want to add this icon, but as requested in #3361 it does have more use cases that would be applicable as tags.

Additionally, I feel like the design is probably too small, see the design ideas also in #3361

@jguddas
Copy link
Member

jguddas commented Dec 3, 2025

Rotated:
icons
Open lucide studio

@idev-code
Copy link

Rotated: iconsOpen lucide studio

nice! agree

@7ender
Copy link
Author

7ender commented Dec 4, 2025

Rotated: iconsOpen lucide studio

Thank you! looks great.

@karsa-mistmere
Copy link
Member

Rotated: iconsOpen lucide studio

I'm in favour of using a diagonal, especially since it works super well with the envelope @jamiemlaw designed, but:

  1. the circle should be grid aligned
  2. I think the orientation is wrong, I can't quite put my finger on why, but this feels much more natural to me:

icons
Open lucide studio

@jamiemlaw
Copy link
Contributor

This was the design of just the diagonal fish-hook I had in my scratchpad:

icons
Open lucide studio

Given that the barb is supposed to be pointy, I've applied minimal rounding to it—just enough, IMO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🎨 icon About new icons 🫧 metadata Improved metadata

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants