Fix: Correct getPathInfo usage in captcha deletion cron #40355
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The DeleteExpiredImages cron was not working since Magento 2.4.8 due to incorrect usage of getPathInfo() method. The method was called with a second parameter (PATHINFO_EXTENSION) which it doesn't support, causing the PNG file extension check to always fail.
Changes:
Root cause:
The getPathInfo() method only accepts one parameter and returns the full pathinfo array. Using PATHINFO_EXTENSION as second parameter was comparing array to string, which always resulted in false.
Manual testing:
Before fix: Files never get deleted, directory grows indefinitely
After fix: Expired PNG files are properly cleaned up
Fixes: #40192
Contribution checklist (*)