Skip to content

Conversation

@ruudvanstrijp
Copy link
Contributor

This pull request adds support for waste collection information for the municipality of Venlo. The changes ensure that Venlo is included as a source and that its specific parameters are available for data retrieval.

New municipality support:

  • Added a new entry for "Gemeente Venlo" to the sources.json file, specifying the use of the ximmio_nl module and setting the default company parameter to "venlo".
  • Updated the EXTRA_INFO list in ximmio_nl.py to include Venlo, with its title, website URL, UUID, and company identifier.

Copilot AI review requested due to automatic review settings December 6, 2025 16:42
@5ila5
Copy link
Collaborator

5ila5 commented Dec 6, 2025

Thanks for your contribution

@5ila5 5ila5 merged commit b128b79 into mampfes:master Dec 6, 2025
6 checks passed
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request adds support for waste collection information for the municipality of Venlo in the Netherlands. The implementation follows the existing patterns and correctly integrates Venlo into the waste collection schedule system using the Ximmio module.

  • Adds Venlo to the SERVICE_MAP in ximmio_nl.py with proper configuration (UUID, company identifier, URL)
  • Registers Venlo as a new source in sources.json with appropriate module and default parameters
  • Updates documentation files (README.md and info.md) to include Venlo in the list of supported municipalities

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
custom_components/waste_collection_schedule/waste_collection_schedule/source/ximmio_nl.py Adds Gemeente Venlo entry to SERVICE_MAP with UUID, URL, and company identifier
custom_components/waste_collection_schedule/sources.json Registers Gemeente Venlo as a new source using ximmio_nl module with default company parameter
README.md Adds Gemeente Venlo to the alphabetically sorted list of Dutch municipalities with proper link to documentation
info.md Adds Gemeente Venlo to the Netherlands list in the supported countries/providers table

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants