feat: replace instruction modal with persistent keyboard shortcuts #91
Conversation
Signed-off-by: PARTHIV PRATIM SAIKIA <[email protected]>
parthivsaikia
force-pushed
the
feat/73-better-instructions
branch
from
1ea77ab to
15105a7
Compare
kishore08-07
left a comment
kishore08-07
left a comment
There was a problem hiding this comment.
@parthivsaikia
It’s inappropriate to edit the package-lock.json unnecessarily,
kindly revert the changes made to package-lock.json.
|
@parthivsaikia |
|
@kishore08-07 I have reverted the changes. Can you check it out? |
|
@parthivsaikia merge conflicts |
|
@saurabhraghuvanshii can you check now |
|
@parthivsaikia LGTM. Just one minor change — the heading text should be larger. Right now, the instruction text is smaller than the description. Please follow the hierarchical structure. |
Signed-off-by: PARTHIV PRATIM SAIKIA <[email protected]>
parthivsaikia
force-pushed
the
feat/73-better-instructions
branch
from
2a38f69 to
8f1ac87
Compare
Signed-off-by: PARTHIV PRATIM SAIKIA <[email protected]>
|
@saurabhraghuvanshii I have changed the font size to 2 rem and increased the margin to 12px. I guess it should work now |
|
@parthivsaikia margin is too much reduce it Please 8px works |
Signed-off-by: Saurabh Singh <[email protected]>
Signed-off-by: Saurabh Singh <[email protected]>
|
@parthivsaikia thanks lgtm |
saurabhraghuvanshii
merged commit b610021
into
meshery-extensions:master
|
Welcome @saurabhraghuvanshii . I was going to reduce the margin to 8px. Is it not needed? |
|
no I done it you can check |
3 participants
Notes for Reviewers
Signed commits
Description
This PR addresses the usability issue where the "Show Instructions" modal would block the drawing grid, preventing users from reading instructions and drawing simultaneously.
Changes:
Show Instructionsbutton and the blockingInstructionsModalcomponent.src/pages/index.jsto accommodate the new layout.This allows users to reference the controls (Enter, Ctrl+Z, etc.) without interrupting their workflow.
Screenshots
Before
After
