Adding working dockerfile with overrideable pytorch base image. #2131
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
|
@johnwhumphreys has exported this pull request. If you are a Meta employee, you can view the originating Diff in D89013574. |
…-pytorch#2131) Summary: This diff adds a working Dockerfile. It has been tested w/ the TorchX kubernetes integration on AWS multi-node. It has an overrideable base image for the nightly from pytorch. The below test plan shows how to log into a devgpu on the cloud, build it, upload it to the ECR registry, test it, then build with an override and test again. A good next step is to automate this with GitHub actions. I feel that building it based on the nightlies is a good move and we should not build this every commit / we should not redo all the build logic separately here as it would be complex and redundant. Reviewed By: thedavekwon Differential Revision: D89013574
johnwhumphreys
force-pushed
the
export-D89013574
branch
from
68c3c40 to
f72c24a
Compare
|
This pull request has been merged in 7a9ef93. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This diff adds a working Dockerfile. It has been tested w/ the TorchX kubernetes integration on AWS multi-node.
It has an overrideable base image for the nightly from pytorch.
The below test plan shows how to log into a devgpu on the cloud, build it, upload it to the ECR registry, test it, then build with an override and test again.
A good next step is to automate this with GitHub actions. I feel that building it based on the nightlies is a good move and we should not build this every commit / we should not redo all the build logic separately here as it would be complex and redundant.
Differential Revision: D89013574