fix/non seekable stream to v3 #2640
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ialization fix: additional properties serialization should not emit a schema in v2 fix: additional properties serialization should not emit booleans in v3.1+
…port/v2--components--Microsoft.OpenApi chore(support/v2): release 2.3.11
…o-v3 Signed-off-by: Vincent Biret <[email protected]>
| var initialPosition = stream.Position; | ||
| var firstByte = (char)stream.ReadByte(); | ||
|
|
||
| // Skip whitespace if present and read the next non-whitespace byte |
There was a problem hiding this comment.
It feels like this comment is misleading. It mentions that it will read the next non-whitespace byte, but actually it seems like it reads the next byte unconditionally, regardless of what character it is. Considering whitespace is insignificant in JSON, it seems fair to assume multiple leading spaces are present. Changing the if to a while seems like it could do the trick?
Member
Author
There was a problem hiding this comment.
Thanks for the suggestion, it was a bit outside of the initial scope but I made the change.
Signed-off-by: Vincent Biret <[email protected]>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2638, reflection of #2639