Skip to content

Conversation

@NirajC-Microsoft
Copy link
Contributor

This pull request modifies the logic for generating the solutionPrefix variable in the infra/main.bicep file to improve uniqueness and ensure consistency. The change adjusts the parameters used in the uniqueString function and their order.

Key change:

  • Improved solutionPrefix uniqueness logic:
    • Updated the uniqueString function to include resourceGroup().name and reordered the parameters to prioritize subscription().id, environmentName, and resourceGroup attributes. This ensures a more unique and consistent prefix generation. ([infra/main.bicepL72-R72](https://github.com/microsoft/document-generation-solution-accelerator/pull/516/files#diff-7ef659fc9cf6968e718894d300490b14ea7a52091e7d4bcffae3a5029ac721d4L72-R72))## Purpose
  • ...

Does this introduce a breaking change?

  • Yes
  • No

Golden Path Validation

  • I have tested the primary workflows (the "golden path") to ensure they function correctly without errors.

Deployment Validation

  • I have validated the deployment process successfully and all services are running as expected with this change.

What to Check

Verify that the following are valid

  • I have built and tested the code locally and in a deployed app
  • For frontend changes, I have pulled the latest code from main, built the frontend, and committed all static files.
  • This is a change for all users of this app. No code or asset is specific to my use case or my organization.

Other Information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants