-
Notifications
You must be signed in to change notification settings - Fork 150
fix: merging dev to main #527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: Model Deployment When Reusing Existing Foundry Service/Projects
feat: Agent and thread management
feat: replacing DefaultAzureCredential with ManagedIdentityCredential
fix: Added Validation for Supported regions for AI deployment location
feat: Added unit tests for Azure credential utilities
refactor: Changed Async and Sync Azure credential retrieval
Prajwal-Microsoft
approved these changes
Jul 31, 2025
Contributor
|
🎉 This PR is included in version 1.6.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request introduces several updates to enhance AI model deployment capabilities, improve configuration flexibility, and update authentication mechanisms in deployment scripts. The changes primarily focus on adding support for AI model deployments, updating environment variables, and replacing the credential type in Python scripts.
AI Deployment Enhancements:
aiModelDeploymentsparameter ininfra/deploy_foundry_role_assignment.bicepandinfra/main.bicep. This includes defining deployment properties such as model name, format, and SKU. ([[1]](https://github.com/microsoft/document-generation-solution-accelerator/pull/527/files#diff-801321770c4260aea129a24ab905704034ec515f2811ee5d93a6fc7c2d29c626R242),[[2]](https://github.com/microsoft/document-generation-solution-accelerator/pull/527/files#diff-14e63a7cd6462bdb2d4ca3a194ccf9b80e4a49512ede9eddd720dd0316d72809R6),[[3]](https://github.com/microsoft/document-generation-solution-accelerator/pull/527/files#diff-14e63a7cd6462bdb2d4ca3a194ccf9b80e4a49512ede9eddd720dd0316d72809R17-R34),[[4]](https://github.com/microsoft/document-generation-solution-accelerator/pull/527/files#diff-0504f5a35afecd5c8c2a1dc8cac5bb558cc1456c557d8edcb7f9bac1c0dc36e4R1465-R1494),[[5]](https://github.com/microsoft/document-generation-solution-accelerator/pull/527/files#diff-0504f5a35afecd5c8c2a1dc8cac5bb558cc1456c557d8edcb7f9bac1c0dc36e4R2421-R2450))Configuration Updates:
azureAiAgentApiVersionandAPP_ENV, to support additional environment configurations and API versions ininfra/deploy_app_service.bicepandinfra/main.bicep. ([[1]](https://github.com/microsoft/document-generation-solution-accelerator/pull/527/files#diff-37c8b5694d17291d641a19fb8a562e30642066b4bf8b8657f2636f50567cf4ebR34),[[2]](https://github.com/microsoft/document-generation-solution-accelerator/pull/527/files#diff-37c8b5694d17291d641a19fb8a562e30642066b4bf8b8657f2636f50567cf4ebL270-R275),[[3]](https://github.com/microsoft/document-generation-solution-accelerator/pull/527/files#diff-37c8b5694d17291d641a19fb8a562e30642066b4bf8b8657f2636f50567cf4ebR301-R304),[[4]](https://github.com/microsoft/document-generation-solution-accelerator/pull/527/files#diff-7ef659fc9cf6968e718894d300490b14ea7a52091e7d4bcffae3a5029ac721d4R66-R68),[[5]](https://github.com/microsoft/document-generation-solution-accelerator/pull/527/files#diff-0504f5a35afecd5c8c2a1dc8cac5bb558cc1456c557d8edcb7f9bac1c0dc36e4L2228-R2294),[[6]](https://github.com/microsoft/document-generation-solution-accelerator/pull/527/files#diff-0504f5a35afecd5c8c2a1dc8cac5bb558cc1456c557d8edcb7f9bac1c0dc36e4R2331-R2334))infra/main.bicepandinfra/main.json. ([[1]](https://github.com/microsoft/document-generation-solution-accelerator/pull/527/files#diff-7ef659fc9cf6968e718894d300490b14ea7a52091e7d4bcffae3a5029ac721d4R17-R36),[[2]](https://github.com/microsoft/document-generation-solution-accelerator/pull/527/files#diff-0504f5a35afecd5c8c2a1dc8cac5bb558cc1456c557d8edcb7f9bac1c0dc36e4R37-R56))Authentication Mechanism Updates:
DefaultAzureCredentialwithAzureCliCredentialin Python scripts for accessing Azure resources, improving compatibility with local development environments. ([[1]](https://github.com/microsoft/document-generation-solution-accelerator/pull/527/files#diff-114b4ad9068b197a6e38361b5e9f53963126cfe2452a59ec1b2e7235444f456aL1-R1),[[2]](https://github.com/microsoft/document-generation-solution-accelerator/pull/527/files#diff-114b4ad9068b197a6e38361b5e9f53963126cfe2452a59ec1b2e7235444f456aL30-R34),[[3]](https://github.com/microsoft/document-generation-solution-accelerator/pull/527/files#diff-114b4ad9068b197a6e38361b5e9f53963126cfe2452a59ec1b2e7235444f456aL46-R46),[[4]](https://github.com/microsoft/document-generation-solution-accelerator/pull/527/files#diff-fbe3aac5bf15aad7b48d6fbf6058d433d343bdf35344cbcd2bfc1830048d248cL10-R10),[[5]](https://github.com/microsoft/document-generation-solution-accelerator/pull/527/files#diff-fbe3aac5bf15aad7b48d6fbf6058d433d343bdf35344cbcd2bfc1830048d248cL25-R29))These changes collectively enhance the deployment pipeline's flexibility, scalability, and ease of use, particularly for AI-related resources.
Does this introduce a breaking change?
Golden Path Validation
Deployment Validation
What to Check
Verify that the following are valid
Other Information