Skip to content

Conversation

@Roopan-Microsoft
Copy link
Contributor

@Roopan-Microsoft Roopan-Microsoft commented Sep 15, 2025

Purpose

  • This pull request removes several Bicep infrastructure modules and updates documentation and workflow configuration to reflect changes in deployment options and resource parameterization. The main impact is the removal of individual Bicep files for key Azure resources, likely in favor of consolidation or a new deployment approach. Additionally, deployment documentation is updated to clarify sandbox vs. Well-Architected Framework (WAF) aligned production deployments, and a workflow variable is renamed for consistency.

Infrastructure Module Removal:

  • Deleted Bicep modules for provisioning key Azure resources, including managed identity (infra/deploy_managed_identity.bicep), key vault (infra/deploy_keyvault.bicep), Cosmos DB (infra/deploy_cosmos_db.bicep), storage account (infra/deploy_storage_account.bicep), post-deployment scripts (infra/deploy_post_deployment_scripts.bicep), index scripts (infra/deploy_index_scripts.bicep), and foundry role assignment (infra/deploy_foundry_role_assignment.bicep). This removes resource parameterization and output definitions for these components. [1] [2] [3] [4] [5] [6] [7]

Documentation Improvements:

  • Expanded deployment guide (docs/DeploymentGuide.md) to explain the difference between sandbox and WAF-aligned production deployments, including instructions on selecting configuration files and customizing VM credentials. Added notes about active development of WAF best practices.

Workflow Configuration Update:

  • Renamed workflow environment variable from aiDeploymentsLocation to azureAiServiceLocation in .github/workflows/deploy.yml for improved clarity and consistency.

Does this introduce a breaking change?

  • Yes
  • No

Golden Path Validation

  • I have tested the primary workflows (the "golden path") to ensure they function correctly without errors.

Deployment Validation

  • I have validated the deployment process successfully and all services are running as expected with this change.

What to Check

Verify that the following are valid

  • I have built and tested the code locally and in a deployed app
  • For frontend changes, I have pulled the latest code from main, built the frontend, and committed all static files.
  • This is a change for all users of this app. No code or asset is specific to my use case or my organization.

Other Information

@Prajwal-Microsoft Prajwal-Microsoft merged commit 6142454 into main Sep 18, 2025
12 checks passed
@github-actions
Copy link
Contributor

🎉 This PR is included in version 1.6.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants