nes: joint: fix ghost-text provider returning no-op edits to UI #2479
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug where the ghost-text provider (joint inline completion provider) was returning no-op edits to the UI, which could prevent good NES (Next Edit Suggestions) edits from being shown. The fix introduces filtering logic to detect and ignore completions/edits that don't actually change the document content.
Key Changes
- Refactored in-flight request tracking from counters to Set-based tracking with proper cancellation token handling
- Added
retainOnlyMeaningfulEditsmethod to filter out no-op edits by comparing the original text with the proposed insertion - Updated
_returnCompletionsOrOtherwiseNESto filter both completions and NES responses before returning them
src/extension/inlineEdits/vscode-node/jointInlineCompletionProvider.ts
Outdated
Show resolved
Hide resolved
src/extension/inlineEdits/vscode-node/jointInlineCompletionProvider.ts
Outdated
Show resolved
Hide resolved
chrmarti
previously approved these changes
Dec 8, 2025
this would sometimes prevent good NES edits from being shown
ulugbekna
force-pushed
the
ulugbekna/nes-joint-ignore-noop-completions
branch
from
0c6e5cb to
48892af
Compare
lszomoru
approved these changes
Dec 8, 2025
ulugbekna
added a commit
that referenced
this pull request
Dec 8, 2025
ulugbekna
added a commit
that referenced
this pull request
Dec 8, 2025
ulugbekna
added a commit
that referenced
this pull request
Dec 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this would sometimes prevent good NES edits from being shown
based on #2478