Cherry-pick upsteam bug fix to expose codec registration methods #132
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without these, the various Sk*Decoder::Decode functions were not properly being marked with SK_API and were not visible to Chromium. Change-Id: I29b5bb630e54a26205a8f562d61929d61bc4aaec Bug: skia:13983 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/714237 Commit-Queue: Kevin Lubick <[email protected]> Auto-Submit: Kevin Lubick <[email protected]> Reviewed-by: Florin Malita <[email protected]>
Author
|
I built Skia within the context of SkiaSharp and found out that it only exposes the C API, and building with both C and C++ exports fails. So for the purpose of SkiaSharp, a further patch would be needed to expose |
|
I believe that with my bump last night to the 117 milestone, this commit is now included! Thanks for this PR, hopefully I can keep skia more up-to-date and we never need to cherry pick (unless we are ready to eat those cherries and we are in the garden). |
|
Closing this for now as it got merged for free. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Cherry pick of google/skia@ec70dfb
This commit exports
SkCodec::Registerfrom the library. The method accepts a C++ object so can't be easily wrapped in C#, but exposing it costs nothing and does at least enable users of SkiaSharp to register codecs by creating a native library. We want to do exactly this in our product.SkiaSharp Issue
Fixes mono/SkiaSharp#2992
API Changes
Added:
SkCodec::RegisterSKCodec::DecoderBehavioral Changes
None.
Required SkiaSharp PR
None.
PR Checklist
skiasharpat time of PR