Skip to content

Fix cd command hook bug and add an option to disable it #485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Inndy wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix cd command hook bug and add an option to disable it #485

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
41e7085
Fix `cd` command hook bug
Inndy Jul 24, 2024
f878ebf
Add option GVM_DISABLE_CD_HOOK to opt-out of `cd` hook
Inndy Jul 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions scripts/env/cd
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
#!/usr/bin/env bash

# To disable this cd hook and prevent potential slowdowns, set GVM_DISABLE_CD_HOOK to a non-empty string.
[ -n "$GVM_DISABLE_CD_HOOK" ] && return

# Override the cd() function to implement auto-switching of go version and
# pkgset when changing into a directory.

Expand All @@ -19,7 +22,7 @@ fi
if __gvm_is_function cd; then
eval "$(echo "__gvm_oldcd()"; declare -f cd | sed '1 s/{/\'$'\n''{/' | tail -n +2)"
elif [[ "$(builtin type cd)" == "cd is a shell builtin" ]]; then
eval "$(echo "__gvm_oldcd() { builtin cd \$*; return \$?; }")"
eval "$(echo "__gvm_oldcd() { builtin cd \"\$@\"; return \$?; }")"
fi

# Path cleanup
Expand All @@ -46,7 +49,7 @@ export PATH="$(__gvm_munge_path)"
cd() {
# @FIXME: gvm_oldcd is broken on re-sourcing .bashrc!
if __gvm_is_function __gvm_oldcd; then
__gvm_oldcd $*
__gvm_oldcd "$@"
fi

local dot_go_version dot_go_pkgset rslt
Expand Down