-
Notifications
You must be signed in to change notification settings - Fork 3
Import police data for EVAW hub #702
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 700-safeguarding-data
Are you sure you want to change the base?
Conversation
0d0e55e to
b6762a6
Compare
b6762a6 to
fab9345
Compare
zarino
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of suggestions re: wording, as requested!
conf/imports.json
Outdated
| }, | ||
| { | ||
| "name":"reported_rapes_per_100k", | ||
| "label":"Reported Rapes per 100k", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
“Reported incidents of rape, per 100,000 people” perhaps?
conf/imports.json
Outdated
| }, | ||
| { | ||
| "name":"reported_rapes", | ||
| "label":"Reported Rapes", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
“Total reported incidents of rape” perhaps?
| "subcategory":null, | ||
| "release_date":"July 2025", | ||
| "source_label":"UK and Scottish governments, combined by mySociety", | ||
| "source":"https://www.gov.uk/government/statistical-data-sets/police-recorded-crime-and-outcomes-open-data-tables, https://www.gov.scot/collections/recorded-crime-in-scotland/", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A minor thing, but I think this will cause an issue in the Area and Sources templates, where they expect the dataset’s source url to be a single URL which can be put inside the href attribute of a single link. If we want datasets with multiple sources (good idea!) we will need to update the template and/or view to handle that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh, yes, yes it will. I will leave it as now and then we can sort it out later, if that's ok?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep! Can you ticket up, so we don’t forget?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ticket at #705
fab9345 to
82aefc3
Compare
it falls over on na values also do fill blanks first so that they don't get dropped
This doesn't fix the JS that's doing this
We're starting to add data which is the same value over a number of years so best to mark the explicitly so we can display it sensibly
Does this as a line graph, with a plugin to sort out avoiding label/legend overlap because that's the only way. Also make sure the minimum value on the x axis is always 0. We can hard code this because it's also fine for the horizontal bar charts we have
Make sure it splits it out a la range data
If you use both you end up replacing data and as the DIS councils don't cover everything you end up with bad data, so only use STC
adds a filter option to import from config that lets you only import rows where the confuigured column matches the specified value
includes a generator script that gathers all the data and turns it into an easy to import format
Also remove a duplicated `is_range` key in imports.json and provide a better source URL for the safeguarding datasets.
- Make it clear that this is a recommended _minimum_ - Round up to nearest whole number (you can’t have half a refuge centre)
e10e717 to
cdf0761
Compare
Fixes #680