Skip to content

add --no-colors if not in a tty. #3715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
denshade wants to merge 4 commits into
base: master
Choose a base branch
from
+21 −0
Open

add --no-colors if not in a tty. #3715

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c71e946
add --no-colors if not in a tty.
denshade Nov 22, 2025
1f7d484
add test
denshade Nov 23, 2025
e901c33
Update nvm.sh
denshade Nov 25, 2025
ffea698
Update nvm.sh
denshade Nov 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions nvm.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4088,6 +4088,10 @@ nvm() {
local NVM_NO_COLORS
local NVM_NO_ALIAS

if ! command tty -s <&1; then
command set -- "$@" "--no-colors"
fi

while [ $# -gt 0 ]; do
case "${1}" in
--) ;;
Expand Down
17 changes: 17 additions & 0 deletions test/fast/Listing versions/Running 'nvm ls' with piped output does not contain colors
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
#!/bin/sh

die () { echo "$@" ; exit 1; }

\. ../../../nvm.sh
\. ../../common.sh

make_fake_node v0.0.1

output=$(nvm ls | cat)

if printf '%s' "$output" | grep -Eq '\x1b\[[0-9;]*m'; then
die "FAIL: nvm ls printed colors when piped"
exit 1
else
echo "PASS: no colors when piped"
fi
Loading