Rely on stable ROS 2 packages #69
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yadunund <[email protected]>
Signed-off-by: Yadunund <[email protected]>
vahetag
approved these changes
Apr 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #68
When we started working on
bpc,rmw_zenoh_cppbinaries were not available on mainline (main) ROS 2 Jazzy just yet. The package was bloomed and binaries were available in theros2-testingrepository. Hence, the docker images relied on a "hack" to update the system's sources list to pull packages fromros2-testinginstead ofmain.Since then, we have stable binaries of
rmw_zenoh_cpponmainbut we forgot to remove the hack. This causes the image to continue pulling fromros2-testingwhich is dangerous as there could be several regressions or even deleted packages in ros2-testing which could lead to the system being in an unstable state.This PR simply deletes the "hack" and adds an
apt upgradecommand to ensure the system has the latest stable binaries of ROS 2 Jazzy.