Change rangeX and rangeY to u8 in ObjectEvent struct #2176
Merged
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Will this break saves for users that are already building with modern? |
Contributor
Author
|
As I said in the description I haven't tested it myself as I don't have modern build enviroment setup but according to the pull request I linked it shouldn't break it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This seems to be the more correct type than u16 as the data only needs 8 bits. On agbcc this makes no difference but when compiling the same code in x86 using gcc it causes this struct to be a different size which breaks save file compatibility, changing the type to u8 makes the struct correct size. I have not tested this on ARM gcc modern myself but according to pull request #2118 changing the type u8 should give the correct struct size too.
Discord contact info
nt_x86