Skip to content

Conversation

@picsel2
Copy link

@picsel2 picsel2 commented Apr 26, 2024

Description

This PR adds an imput parameter "squash" allowing optional layer squashing when building from scratch.

Related Issue(s)

Closes #138

Checklist

  • This PR includes a documentation change
  • This PR does not need a documentation change

  • This PR includes test changes
  • This PR's changes are already tested

  • This change is not user-facing
  • This change is a patch change
  • This change is a minor change
  • This change is a major (breaking) change

Changes made

  • Introduction of input argument squash (defaulting to true)
  • Set --squash argument conditionally for the buildah config command line

required: false
squash:
description: 'Set to true to squash the image layers.'
default: 'true'
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This to me is a bad default for this option. A default like this should mimic the existing behavior, and not a new behavior.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am a bit confused here. The existing behaviour (at least when I opened this PR) is to squash all layers, see #138

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see your point. That is indeed the existing behavior.

I would argue then that not squashing is a better default in general. :)

@skoved skoved removed this from Issue Tracking Aug 21, 2025
@skoved skoved moved this to Need Review in Issue Tracking Aug 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Need Review

Development

Successfully merging this pull request may close these issues.

[FEATURE] Make --squash argument optional

2 participants