Record user who cancelled a task [RHELDST-460] #271
Conversation
When cancelling a task there is no recorded information of who cancelled the task, simply that it was cancelled. This is unhelpful to users if someone else cancels their task or push. This change adds in the components for being able to show which user cancelled the task.
amcmahon-rh
force-pushed
the
cancelled_by
branch
from
f2c47aa to
8a66a11
Compare
|
The upstream CI of OpenScanHub uses the HEAD of this repository. After this pull request was merged, the CI started to fail with: If I pin |
|
@amcmahon-rh @rbikar Any explanation for the above mentioned consequences? |
... to keep the nomenclature consistent with the `CANCELED` state. Related: release-engineering#271
... to eliminate the following failure while applying migrations: ``` + osh/hub/manage.py migrate SystemCheckError: System check identified some issues: ERRORS: hub.Task.cancelled_by: (fields.E304) Reverse accessor 'User.task_set' for 'hub.Task.cancelled_by' clashes with reverse accessor for 'hub.Task.owner'. HINT: Add or change a related_name argument to the definition for 'hub.Task.cancelled_by' or 'hub.Task.owner'. hub.Task.owner: (fields.E304) Reverse accessor 'User.task_set' for 'hub.Task.owner' clashes with reverse accessor for 'hub.Task.cancelled_by'. HINT: Add or change a related_name argument to the definition for 'hub.Task.owner' or 'hub.Task.cancelled_by'. ``` Related: release-engineering#271 Related: openscanhub/openscanhub#317 Closes: release-engineering#273
|
I have submitted #273 to fix this. |
|
I asked privately @amcmahon-rh to have a look, but I guess he hasn't had a chance to fix it. |
|
Heyo, I was looking at it and had a PR ready to open, but Kamil beat me to it. I was thinking of using the "+" to tell Django not to create a reverse relationship (the user not having access to tasks they cancelled), but I think having the same sort of Edit: I am a bit surprised there was an issue though. Before merging this PR, I tested the migrations on a pub pod locally, and it appeared to run fine. |
|
The OSH CI runs tests on el8/el9 using the |
fix a regression caused by #271
3 participants
When cancelling a task there is no recorded information of who cancelled the task, simply that it was cancelled. This is unhelpful to users if someone else cancels their task or push.
This change adds in the components for being able to show which user cancelled the task.