Skip to content

Flaky test fix: allow ThreadPool to shutdown before asserting completed_task_count #1098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bensheldon merged 1 commit into from
Dec 11, 2025
+9 −10
Merged

Flaky test fix: allow ThreadPool to shutdown before asserting completed_task_count #1098

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 9 additions & 10 deletions spec/concurrent/executor/thread_pool_shared.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,16 +86,15 @@
it 'returns zero on creation' do
expect(subject.completed_task_count).to eq 0
end

unless Concurrent.on_jruby?

it 'returns the approximate number of tasks that have been completed thus far' do
5.times{ subject.post{ raise StandardError } }
5.times{ subject.post{ nil } }
subject.post { latch.count_down }
latch.wait(1)
expect(subject.completed_task_count).to be > 0
end

it 'returns the approximate number of tasks that have been completed thus far' do
5.times{ subject.post{ raise StandardError } }
5.times{ subject.post{ nil } }
subject.post { latch.count_down }
latch.wait(1)
subject.shutdown
expect(subject.wait_for_termination(pool_termination_timeout)).to eq true
expect(subject.completed_task_count).to be > 0
end
end

Expand Down