add crate-name validation to web endpoints #3077
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syphar
changed the title
github-actions
bot
added
the
S-waiting-on-review
syphar
force-pushed
the
validation-web
branch
from
50cb808 to
00564ed
Compare
syphar
force-pushed
the
validation-web
branch
from
00564ed to
2dcecfe
Compare
Member
|
Normally you don't need to push sqlx files, our CI will handle it. ;) |
GuillaumeGomez
approved these changes
Dec 12, 2025
github-actions
bot
added
S-waiting-on-deploy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for now, copy/paste the subcrate we want to have published for clarity.
Then this PR migrates most web handlers working with crate names to use the newtype first. This makes it possible to decline a bunch of requests without any database query.
Only handler where we needed a little more work was the
rustdoc_redirector_handlerwhere we have to handle some non-crate cases before we can validate.I intentionally limited the migration to just a first block, otherwise the new types leak into the whole codebase.
And I want to do the migration step by step.