S3Trio64 Linear Framebuffer compute fix #312
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Existing code utilized an 8MB LFB size for all 4MB cards. PCem supports Vision864, which can run a maximum of 8MB memory, but all 4MB S3 cards were being given the 8MB LFB This brings over the correct handling per Trio32/64 development manual and 86box implementation Update vid_s3.c Update vid_s3.c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Existing code utilized an 8MB LFB size for all 4MB cards. PCem supports Vision864, which can run a maximum of 8MB memory, but all 4MB S3 cards were being given the 8MB LFB
This brings over the correct handling per Trio32/64 development manual from the 86box implementation
Noticed this while working on an Alpha/AXP emulator implementing only the Trio64 and was using various existing working implementations as references.
Since pcem officially supports a Vision864 based card, which can have a maximum of 8MB memory, this will present a correct LFB if that option is ever added to that card and will correct Trio64 based card representations now.