Dollars in idents

[som-snytt]

Warns on definitions named with embedded dollars, which should must be written in backquotes, if at all.

Fixes #18234

Test from #18563

[sjrd]

which should be written in backquotes

They should not be written at all, in fact. ;)

[som-snytt]

This proposal aims to accommodate the two views, which are not entirely incompatible, that strict enforcement is required and yet Java doesn't need it so why does Scala?, where the question is posed with a large dosage of skepticism about warnings.

Here, there is no forking compiler option. Definitions with suspect names are disallowed, with a migration warning now and an error later. However, the workaround, to permit the identifier in backquotes, is quite natural and pleasant, as we have all come to savor backquotes in new syntactic contexts. Backquotes are not required for references (usages).

CB c includes the original izumi-reflect example.

A rewrite will be offered in a follow-up. The corner case is pattern variables, where it's not sufficient to simply wrap the identifier in backquotes.

[sjrd]

@Gedochao What's the warning policy for the feature freeze?

Should this be

Suggested change

	case IdentifierDollars extends MigrationVersion(`3.8`, `3.9`)
	case IdentifierDollars extends MigrationVersion(`3.10`, `3.11`)

at this point?

Or can we get away with

Suggested change

	case IdentifierDollars extends MigrationVersion(`3.8`, `3.9`)
	case IdentifierDollars extends MigrationVersion(`3.8`, `3.10`)

even though the warning would then be introduced in a patch version?

[Gedochao]

my gut says the former (3.10, 3.11), but I probably could be convinced otherwise.
We haven't had a precedent for this, I guess.
let's discuss it on today's Scala Core.

[sjrd]

Sometimes this method is called as a function, sometimes as an extension. That's confusing. Given that you sometimes need it just for the side effect, consider standardizing on the function variant:

Suggested change

	extension (nameTree: NameTree) def checkName: nameTree.type =
	def checkName(nameTree: NameTree): nameTree.type =

[som-snytt]

I will consider it. This was my first opportunity to use an extension "both ways", which I think is a feature of extensions.