Create placeholder symbols for checking callee and improve TypeVar instantiation logic #24697
+114
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Dec 8, 2025
…ed when there exists a TypeVar in pt
noti0na1
force-pushed
the
fix-function-param-placeholder-symbols
branch
from
36dc33a to
dc3281e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refines the
TypeVarinstantiation logic introduced by #24231.We only check the
calleeTypewhen there is actually aTypeVarinptto instantiate now, prioritizing inference from the callee.Close #24686 #24689 #24694 #24696
Maybe #24695, since the behaviour is the same as 3.3 and 3.7 now.
calleeTypeitself still has some issues, will fix in a separate PR: #24732