Skip to content

Conversation

@hamzaremmal
Copy link
Member

@hamzaremmal hamzaremmal requested a review from a team as a code owner December 10, 2025 21:24
@som-snytt
Copy link
Contributor

I would expect the PR to improve library first, and this second.

@hamzaremmal
Copy link
Member Author

I would expect the PR to improve library first

What do you have in mind?

@som-snytt
Copy link
Contributor

util.chaining was the first thing people wanted to inline. I guess -> is the second. #24715

@hamzaremmal
Copy link
Member Author

util.chaining was the first thing people wanted to inline. I guess -> is the second. #24715

Aaah, I see what you mean. Sure. This could (will?) be done soon. Even if I do it, it will not be merged until we start working on 3.10.
This PR is just about removing duplicates in the complier codebase. It can always use the new versions later without requiring any changes.

@som-snytt
Copy link
Contributor

I would pause this change until the improvements land, since that was the reason to use compiler util in the first place. The difference is potentially severe, since .tap could turn up in hot code and is supposed to be without cost.

@hamzaremmal
Copy link
Member Author

It is here: #24725.

@bishabosha
Copy link
Member

bishabosha commented Dec 11, 2025

lets say blocked until non-bootstrapped compiler uses result of #24725?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants