Tweak cc error messages #24733
Open
Tweak cc error messages #24733
+235
−136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improve rendering of messages with multi-line code positions. Two improvements: - Add a blank line between the error message proper and the code lines that follow it. - If there are more than 3 code lines following it, summarize them by printing the first and last line and a `...` in between.
Sometimes we have more than one representation of the same symbol, i.e.
both `^` and `cap`, or both `=>` and `cap`. If the cap is rendered first, we expand
the following string to `^{cap}` or `->{cap}` in order make it clearer that
they are the same. Unfortunately it only works if the cap comes first.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes we have more than one representation of the same symbol, i.e.
both
^andcap, or both=>andcap. If the cap is rendered first, we expandthe following string to
^{cap}or->{cap}in order make it clearer thatthey are the same. Unfortunately it only works if the cap comes first.