Refactor pre-commit hook #1309
Merged
Refactor pre-commit hook #1309
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 24, 2025 15:25
stevenchalem
approved these changes
Oct 24, 2025
Contributor
stevenchalem
left a comment
stevenchalem
left a comment
There was a problem hiding this comment.
Tested under Windows 11.
This is a nice improvement!
rjyounes
approved these changes
Oct 25, 2025
Collaborator
|
Note - this has been merged but not to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #891
This branch is stacked on the #1304 branch.
This moves all of the pre-commit logic into a separate file which is called by the new pre-commit hook.
This means that changes in the pre-commit-code file will automatically be used in the future as we make changes.
I think this is a better solution than the one I originally proposed, which checked if there was an update and told the user to re-run setup.cmd.