[loader] enable private loader #14620
Open
+12
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yinghai
requested review from
Fridge003,
Ying1123,
hnyls2002,
ispobock and
merrymercy
as code owners
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
yinghai
commented
Dec 8, 2025
|
|
||
| def model_load_weights(model, iter): | ||
| DefaultModelLoader.load_weights_and_postprocess(model, iter, target_device) | ||
| loader.load_weights_and_postprocess(model, iter, target_device) |
Contributor
Author
There was a problem hiding this comment.
we already enforces that the loader needs to be an DefaultModelLoader instance in L942
| if load_config.load_format == LoadFormat.PRIVATE: | ||
| import importlib | ||
| try: | ||
| module = importlib.import_module("sglang.private.private_model_loader") |
Contributor
Author
There was a problem hiding this comment.
use importlib to avoid circular deps lint
Collaborator
There was a problem hiding this comment.
btw for circular deps lint another way may be use comments # noqa: ... etc to ignore it
Contributor
Author
There was a problem hiding this comment.
the lint showed up on the private lib part lol
| param = params_dict[name] | ||
| else: | ||
| continue | ||
| raise ValueError(f"Weight {name} not found in params_dict") |
fzyzcjy
approved these changes
Dec 8, 2025
| if load_config.load_format == LoadFormat.PRIVATE: | ||
| import importlib | ||
| try: | ||
| module = importlib.import_module("sglang.private.private_model_loader") |
Collaborator
There was a problem hiding this comment.
btw for circular deps lint another way may be use comments # noqa: ... etc to ignore it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Add a choice to enable private loader for flexibility.
Modifications
Accuracy Tests
Benchmarking and Profiling
Checklist