Skip to content

feat: container scan support for cgo and stripped Go binaries #6353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
adrobuta wants to merge 1 commit into
base: main
Choose a base branch
from
+21 −8
Open

feat: container scan support for cgo and stripped Go binaries #6353

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@
"semver": "^6.0.0",
"snyk-config": "^5.0.0",
"snyk-cpp-plugin": "2.24.1",
"snyk-docker-plugin": "8.12.2",
"snyk-docker-plugin": "8.13.0",
"snyk-go-plugin": "1.28.0",
"snyk-gradle-plugin": "5.1.1",
"snyk-module": "3.1.0",
Expand Down
Binary file added test/fixtures/container-projects/stripped-go-binaries-minimal.tar.gz
View file
Open in desktop
Binary file not shown.
13 changes: 13 additions & 0 deletions test/jest/acceptance/snyk-container/container.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,6 +156,19 @@ describe('snyk container', () => {
expect(code).toEqual(1);
}, 30000);

it('detects stripped Go binaries and reports fleet-server dependencies', async () => {
const { code, stdout } = await runSnykCLI(
`container test docker-archive:test/fixtures/container-projects/stripped-go-binaries-minimal.tar.gz --json`,
);
const jsonOutput = JSON.parse(stdout);

const goModulesResults = jsonOutput.applications?.find((app) =>
app.targetFile?.includes('fleet-server'),
);
expect(code).toEqual(1);
expect(goModulesResults).toBeDefined();
});

it('npm depGraph is generated in an npm image with lockfiles', async () => {
const { code, stdout, stderr } = await runSnykCLIWithDebug(
`container test docker-archive:test/fixtures/container-projects/npm7-with-package-lock-file.tar --print-deps`,
Expand Down