Refactor the extension to use a Sphinx Domain (Updated in 2025) #75
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Print fully-qualified subcommand name in title - Support commands:command role for intersphinx - Prefer fully-qualified HREF targets Use targets like "#blah-sub-commands" as the primary target and move historic targets like "#Sub-commands" to secondary targets. Preserve the older HREF, `sub-commands`, as a secondary target. In the HTML, this becomes a span just below the section element so that bookmarks continue to work even after adopting the update from this commit.
Signed-off-by: Mike McKiernan <[email protected]>
RobertoRoos
commented
Nov 27, 2025
RobertoRoos
commented
Nov 27, 2025
2 tasks
Previously, the xpaths checked the TOC navigation for the expected pages. With this update, the xpaths check for the expected pages in the toctree-generated navigation on the document div. Signed-off-by: Mike McKiernan <[email protected]>
|
Thanks for dusting this off and fixing it up! |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #75 +/- ##
==========================================
+ Coverage 46.86% 51.67% +4.80%
==========================================
Files 12 18 +6
Lines 958 1283 +325
Branches 205 259 +54
==========================================
+ Hits 449 663 +214
- Misses 468 576 +108
- Partials 41 44 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
I failed to rebase this branch onto @ashb what do you think about this? Should we merge the other PRs made by me first? Anything I can do? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Duplicate or renewed version of
I don't think I can push directly in @mikemckiernan 's branch and even if I can not sure I should. So I figured I would have my own PR here.
Of course we could also rebase this branch from my fork into the original feature branch: https://github.com/mikemckiernan/sphinx-argparse/tree/add-domain
Todo: