Polyfill fixups for dealing with calendars #3185
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was causing the overflow: "reject" to be ignored in leap month coercion.
These error messages refer to "Chinese year" because they are in the
helperChinese object, but since helperDangi inherits from that it
results in odd error messages. Use ${this.id} instead.
Latest versions of Node have this "Mo" prefix in their ICU data, which completely broke the Chinese and Dangi calendars.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3185 +/- ##
==========================================
- Coverage 96.96% 96.84% -0.13%
==========================================
Files 22 22
Lines 10217 10235 +18
Branches 1841 1841
==========================================
+ Hits 9907 9912 +5
- Misses 261 273 +12
- Partials 49 50 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
The check for the Indian calendar BCE bug included the literal string "Saka", which has been changed to "Śaka" in the latest ICU data. Ignore the formatted era name and just check the formatted date to see if the host is vulnerable to the bug.
justingrant
approved these changes
Nov 15, 2025
Collaborator
justingrant
left a comment
justingrant
left a comment
There was a problem hiding this comment.
Cool, thanks for catching these. I added a few questions, otherwise looks good.
CLDR has removed the "ERA0" code from the Coptic calendar but it looks like they neglected to actually remove the era - if you try to format a date with a negative era year, it prints a positive era year and omits the era code (the final part of formatToParts() is a literal " " part, which normally should be followed by an era part.) Handle this eventuality with a special case.
We need to do the non-negative modulo here, otherwise all negative years are leap years.
ptomato
force-pushed
the
polyfill-fixups
branch
from
80437ef to
5d09e48
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found these as I wrote tests for Intl Era Monthcode.