Skip to content

auto enabling priority and fairness #8650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
majiru wants to merge 24 commits into
base: main
Choose a base branch
from
Draft

auto enabling priority and fairness #8650

Show file tree
Hide file tree
Changes from 14 commits
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
be61432
add code for auto enabling priority and fairness
majiru Nov 14, 2025
87ae80e
use reasonable timeout for newTaskQueuePartitionManager in tests instead
majiru Nov 14, 2025
36864fa
fix linting issues
majiru Nov 15, 2025
b96901b
Refactor OnChange to be set after initialization through a seperate
majiru Nov 17, 2025
9a41e9a
Push taskQueuePartitionManager initialization into the background
majiru Nov 17, 2025
994cedb
Address comments made in review and simplify implementation
majiru Nov 18, 2025
dd19b25
Fix physicalTaskQueueManager
majiru Nov 18, 2025
0d9eb51
More lint fixes
majiru Nov 18, 2025
7a81262
Guard the defaultQueue behind the future
majiru Nov 19, 2025
f525e0f
We need to wait on ready before checking the cancellation of our
majiru Nov 19, 2025
1bdd110
make linter happy w.r.t deprecated functions
majiru Nov 19, 2025
7b38daf
Rework how we signal and handle waiting on initialization
majiru Nov 21, 2025
c18ce5f
Small linting issue
majiru Nov 21, 2025
b285444
Use an autoenable rpc and address other comments
majiru Nov 26, 2025
1ecb597
Be careful about updating UserData w.r.t. nill members in the path
majiru Dec 2, 2025
03054e9
address comments regarding matching engine handler
majiru Dec 2, 2025
9130ffa
Move matching engine handler to organize a bit better
majiru Dec 2, 2025
26f3636
Address small comments in partition manager
majiru Dec 2, 2025
d28dee6
add GetIfReady() to our future and use it in partition manager
majiru Dec 2, 2025
247c307
address rpc comments
majiru Dec 3, 2025
3a8ff9f
fix generated files
majiru Dec 3, 2025
d0f1b17
add new rpc to quotas
majiru Dec 4, 2025
a533b20
remove duplicate config setting for priority and fairness
majiru Dec 5, 2025
0f93485
Merge branch 'main' into fairness-and-priority-auto-enable
majiru Dec 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
74 changes: 74 additions & 0 deletions api/matchingservice/v1/request_response.go-helpers.pb.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

668 changes: 382 additions & 286 deletions api/matchingservice/v1/request_response.pb.go
View file
Open in desktop

Large diffs are not rendered by default.

161 changes: 83 additions & 78 deletions api/matchingservice/v1/service.pb.go
View file
Open in desktop

Large diffs are not rendered by default.

41 changes: 41 additions & 0 deletions api/matchingservice/v1/service_grpc.pb.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

35 changes: 35 additions & 0 deletions api/matchingservicemock/v1/service_grpc.pb.mock.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

22 changes: 22 additions & 0 deletions api/persistence/v1/task_queues.go-helpers.pb.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading