Populate blob and memo size limits for DescribeNamespace #8734
+13
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simvlad
force-pushed
the
simvlad/populate-blob-memo-limits
branch
from
ca2f486 to
eaf723d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Populates BlobSizeLimitError and MemoSizeLimitError in the response for DescribeNamespace
Why?
Currently the BlobSizeLimitError and MemoSizeLimitError are terminating the workflow with the check performed on the server. In order, for SDK to enforce and fail workflow task, we need to pass those to the SDK. temporalio/api#670 is the change that added those limits to the NamespaceInfo structure.
How did you test it?
Potential risks
No risks, as those are not used yet.