-
Notifications
You must be signed in to change notification settings - Fork 107
Use long options for pg_isready and pg_restore #4519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Using long options improves readability. Verified locally on EL 9.7: $ pg_restore --help | grep -- "--dbname\|--host=\|--port=\|--username=\|--clean" | sort -u -c, --clean clean (drop) database objects before recreating -d, --dbname=NAME connect to database name -h, --host=HOSTNAME database server host or socket directory -p, --port=PORT database server port number -U, --username=NAME connect as specified database user $ pg_isready --help | grep -- "--dbname\|--host=\|--port=\|--username=\|--clean" | sort -u -d, --dbname=DBNAME database name -h, --host=HOSTNAME database server host or socket directory -p, --port=PORT database server port -U, --username=USERNAME user name to connect as
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpdates PostgreSQL command examples in the documentation to use long-form options for pg_isready and pg_restore to improve readability and consistency. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
The PR preview for a472768 is available at theforeman-foreman-documentation-preview-pr-4519.surge.sh The following output files are affected by this PR: |
What changes are you introducing?
Use long options for pg_isready and pg_restore
Why are you introducing these changes? (Explanation, links to references, issues, etc.)
Using long options improves readability.
Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)
Verified locally on EL 9.7:
Contributor checklists
Please cherry-pick my commits into:
Summary by Sourcery
Standardize PostgreSQL utility examples to use long option flags for improved readability.
Documentation: