Skip to content

Conversation

@vchan
Copy link
Collaborator

@vchan vchan commented Dec 3, 2025

BigQuery's STRING_AGG function accepts STRING or BYTES and returns the corresponding type. It also supports optional aggregate clauses like LIMIT, ORDER BY, and DISTINCT. This PR unwraps these expressions in order to annotate types.

BigQuery documentation on its STRING_AGG function: https://docs.cloud.google.com/bigquery/docs/reference/standard-sql/aggregate_functions#string_agg

@VaggelisD
Copy link
Collaborator

VaggelisD commented Dec 3, 2025

Looks like there was a collision with #6463! Initiated a discussion offline for us to solve this moving forward.

For reference, my comment on the other PR would be helpful here too

@georgesittas
Copy link
Collaborator

Closing this in favor of Brad's PR.

@georgesittas georgesittas deleted the vchan/annotate-group-concat branch December 3, 2025 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants