Skip to content

Conversation

@sonicaj
Copy link
Member

@sonicaj sonicaj commented Nov 25, 2025

This PR adds changes to properly support TNC on HA systems ensuring heartbeat only runs on master node and relevant bits of TNC only execute where they should.

@sonicaj sonicaj self-assigned this Nov 25, 2025
@bugclerk bugclerk changed the title TNC support for HA NAS-137503 / 26.04 / TNC support for HA Nov 25, 2025
@bugclerk
Copy link
Contributor

@ZackaryWelch
Copy link
Contributor

@yocalebo @sonicaj We could still have the heartbeat run on the secondary node. No stats are sent, but alerts are, with 'node' indicating the controller. I now have logic on the backend to parse that and tag the alert by controller, then we can query by 'active' or 'standby'.

@yocalebo
Copy link
Contributor

@yocalebo @sonicaj We could still have the heartbeat run on the secondary node. No stats are sent, but alerts are, with 'node' indicating the controller. I now have logic on the backend to parse that and tag the alert by controller, then we can query by 'active' or 'standby'.

@ZackaryWelch after some more internal discussion, I don't believe sending the heartbeat from passive is necessary. Predominantly because that's not the normal paradigm of how we handle services on HA in general. I believe sending the heartbeat only from the active is sufficient. All data about the other controller can be gleaned from the active.

@sonicaj sonicaj removed the WIP label Dec 1, 2025
@sonicaj sonicaj requested review from a team and ZackaryWelch December 1, 2025 06:09
'tn_connect_update.enabled',
'HA systems must be in a healthy state to enable TNC ensuring we have VIP available'
)
for k in filter(lambda k: data[k], ('interfaces', 'use_all_interfaces')):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will we run into any issue with use_all_interfaces as on by default?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HA systems are meant to be used using VIP, @yocalebo do you think we should allow specific or all interfaces ?
Basically these attrs control what IPs we send to TNC based on what is configured on selected/all interfaces.

For public or special ip cases, we are allowing that right now separately

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with disabling that setting for HA, just don't know if there also needs to be a change on registration since it does default to true.

@sonicaj sonicaj requested review from a team and removed request for a team December 6, 2025 17:22
@sonicaj sonicaj requested review from a team and removed request for a team December 9, 2025 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants