-
Notifications
You must be signed in to change notification settings - Fork 535
NAS-137503 / 26.04 / TNC support for HA #17705
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
@ZackaryWelch after some more internal discussion, I don't believe sending the heartbeat from passive is necessary. Predominantly because that's not the normal paradigm of how we handle services on HA in general. I believe sending the heartbeat only from the active is sufficient. All data about the other controller can be gleaned from the active. |
| 'tn_connect_update.enabled', | ||
| 'HA systems must be in a healthy state to enable TNC ensuring we have VIP available' | ||
| ) | ||
| for k in filter(lambda k: data[k], ('interfaces', 'use_all_interfaces')): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will we run into any issue with use_all_interfaces as on by default?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
HA systems are meant to be used using VIP, @yocalebo do you think we should allow specific or all interfaces ?
Basically these attrs control what IPs we send to TNC based on what is configured on selected/all interfaces.
For public or special ip cases, we are allowing that right now separately
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with disabling that setting for HA, just don't know if there also needs to be a change on registration since it does default to true.
This PR adds changes to properly support TNC on HA systems ensuring heartbeat only runs on master node and relevant bits of TNC only execute where they should.