-
Notifications
You must be signed in to change notification settings - Fork 218
Use BCD mediatypes data in existing image format features
#3624
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
| # safari: "16.4" | ||
| # safari_ios: "16.1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a slight difference between web-features and BCD here, with BCD reporting a few minor versions later. I don't think this is significant and does not affect the Baseline low date.
| support: | ||
| chrome: "32" | ||
| chrome_android: "32" | ||
| edge: "79" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BCD doesn't know about support in EdgeHTML (i.e., it's a ≤79 value), so this looks later than the data we have. We could contribute the Edge 18 value upstream. This does not affect the Baseline low date (which hinges on Safari 14).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Contributing the Edge 18 value upstream sounds like the right thing to do. Especially because we can just point to https://caniuse.com/webp as a reference for that value.
This doesn't need to block this PR though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sent mdn/browser-compat-data#28653, which has already been merged. We'll pick this up on the next BCD release.
| firefox: "113" | ||
| firefox_android: "113" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The difference for Firefox is explained by a note at https://caniuse.com/avif. In 93, Firefox only support still avif images. Animated support came in 113.
BCD has added a new tree of data for media-types (modeled mostly after IANA's Media Types) in mdn/browser-compat-data#27168, so we can derive such features' statuses from BCD, instead of supplying our own data.