-
Notifications
You must be signed in to change notification settings - Fork 559
Much better Pro docs #4263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: docs/pro-vs-oss
Are you sure you want to change the base?
Much better Pro docs #4263
Conversation
Documentation Link Check Results❌ Absolute links check failed |
🔍 Broken Links ReportSummary
Details
📂 Full file paths
|
|
https://zenml-io.gitbook.io/alexej/zenml-pro - view here to see it in action |
htahir1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think its good for a first round. many comments apply to many pages
|
|
||
| All three deployment scenarios follow a similar pipeline execution pattern, with differences in where authentication happens and where data resides: | ||
|
|
||
| ### Standard Data Flow Steps |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This definitely needs a diagram
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed - we might even have one laying around somewhere
|
|
||
| **SaaS**: Metadata is stored in ZenML infrastructure. Your ML data and compute remain in your infrastructure. | ||
|
|
||
| **Hybrid**: Metadata and control plane are split — authentication/RBAC happens at ZenML control plane, but all run metadata, artifacts, and compute stay in your infrastructure. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thnk the authentication bit is the most important here and isnt really elaborated but maybe it is later?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What more would you like to know about this at this stage?
|
|
||
| You control this access by configuring appropriate cloud IAM permissions. | ||
|
|
||
| ## Getting Started |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO super strnage to have this whole section here...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the whole section ? maybe we dont need the example pipeline - butt i like how it shows how quickly youi're ready
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm really? its in the dashboard already when you sign up
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
well somebody in the docs here wants to know what complexity awaits them - "Is it worth my time?"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
im not sure tbh
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in my experience these are the questions we get very early on
Co-authored-by: Hamza Tahir <[email protected]>
… docs/better-pro-docs
|
Images automagically compressed by Calibre's image-actions ✨ Compression reduced images by 34%, saving 132.21 KB.
383 images did not require optimisation. Update required: Update image-actions configuration to the latest version before 1/1/21. See README for instructions. |
stefannica
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
first round of reviews, more to follow...
|
|
||
| 1. **Code Execution**: You write code and run pipelines with your client SDK using Python | ||
|
|
||
| 2. **Token Acquisition**: The ZenML client fetches short-lived tokens from your ZenML workspace for: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note: this only happens if you use service connectors
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so what would be a more generally correct statement
| - Artifact lineage graphs | ||
| - Step logs and outputs | ||
|
|
||
| You control this access by configuring appropriate cloud IAM permissions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is misleading. The truth is this: if you give your users permission to access these things, you also implicitly give the UI permission to do so. You could say "you control who can access this information in the UI by configuring appropriate ZenML Pro RBAC permissions. Cloud IAM permissions do not apply here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no don't we have some setting for our wrokspace/UI to enable/disable this?
| ```mermaid | ||
| graph LR | ||
| A[User] -->|1. Login| B[Control Plane<br/>ZenML Infrastructure] | ||
| B -->|2. Auth Token| A | ||
| A -->|3. Access Workspace| C[Workspace<br/>Your Infrastructure] | ||
| C -->|4. Validate Token| B | ||
| B -->|5. Authorization| C | ||
| C -->|6. Execute| D[Your Resources] | ||
| ``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these do not render correctly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
didn't we have a mermaid plugin for gitbook at some point
stefannica
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried to review as much of this as I could. Half of it is pretty good, while the other half is clearly vibe-written and riddled with hallucinations and over-simplifications.
I would kindly ask you to give this another careful read yourself, check that it's factually correct based on the original docs and resources, then correct the mistakes.
|
|
||
| | Data Type | Storage Location | Purpose | | ||
| |-----------|-----------------|---------| | ||
| | User credentials | Control Plane | Authentication only | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The control plane doesn't store user credentials (unless you count Personal Access Tokens or API keys). It's the customer's SSO/identity provider that stores the credentials.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would it be fair to call this user metadata?
| 1. Navigate to `https://zenml.mycompany.com` in your browser | ||
| 2. You should be redirected to ZenML Cloud login | ||
| 3. Sign in with your organization credentials | ||
| 4. You should see your workspace listed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the backwards way of doing it. You should instruct them to log in to cloud.zenml.io, access their org and then their workspace. This redirect is more of a backwards compatibility failsafe than it is an official way of accessing the workspace UI.
| kubectl -n zenml-workload-manager create serviceaccount zenml-runner | ||
| ``` | ||
|
|
||
| ### 2. Configure Workload Manager in Helm Values |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This section is repeated in at least 3 different places:
- here
- in the self-hosted docs
- in the workload managers section
Can you please just point to the workload managers section instead of duplicating this information ?
| external: | ||
| type: mysql | ||
| host: zenml-db.123456789.us-east-1.rds.amazonaws.com | ||
| port: 3306 | ||
| username: admin | ||
| password: <your-rds-password> | ||
| database: zenml_hybrid |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is hallucinated or ill-informed. Please consult the official helm chart values.
| # Add other environment variables as needed | ||
| ``` | ||
|
|
||
| ## Database Configuration Examples |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This entire section is unnecessary. We already have a complete section on how to configure the helm chart for OSS server deployments. Duplicating oversimplified parts of that here - and incorrectly at that - isn't going to help anyone. Better to link to the correct and fully detailed OSS helm documentation here instead.
| external: | ||
| type: mysql | ||
| host: 34.123.45.67 | ||
| port: 3306 | ||
| username: root | ||
| password: <your-cloud-sql-password> | ||
| database: zenml_hybrid |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hallucinated. I won't repeat this comment....
Co-authored-by: Stefan Nica <[email protected]>
… docs/better-pro-docs
Co-authored-by: Stefan Nica <[email protected]>
Co-authored-by: Stefan Nica <[email protected]>
Describe changes
I added a section per deployment scenario - https://zenml-io.gitbook.io/alexej/zenml-pro
Pre-requisites
Please ensure you have done the following:
developand the open PR is targetingdevelop. If your branch wasn't based on develop read Contribution guide on rebasing branch to develop.Types of changes