Move publish step to GitHub Action & use env var instead of --token #594
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdanish-kh
commented
Apr 4, 2025
|
|
||
| ## Build status | ||
|
|
||
| [](https://microsoft.visualstudio.com/Apps/_build/latest?definitionId=64953&repoName=microsoft%2Fwinget-create&branchName=main) |
Contributor
Author
There was a problem hiding this comment.
Not sure where I can get the correct URL for this as it's currently broken. I looked at winget-cli's link and tried to copy it but for winget-create it looks like:
[)](https://dev.azure.com/shine-oss/winget-create/_build/latest?definitionId=17&branchName=main)
Doesn't say succeeded or failure like how the winget-cli one does
mdanish-kh
force-pushed
the
ci-env-var-action
branch
from
cb95805 to
c99ba81
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change
Move azure pipeline step to a GitHub Action. Using an environment variable instead of
--tokenparam as per the latest recommendation. To add a personal access token (PAT), one can follow the steps listed in https://github.com/microsoft/winget-create?tab=readme-ov-file#github-personal-access-token-classic-permissions. We'll need to create a repository secret with a nameWINGET_CREATE_GITHUB_TOKEN(can choose smth else too)Updated the README with the latest changes and resolved formatting markdownlint errors as well
Microsoft Reviewers: Open in CodeFlow