chore: deprecate scala.util.ChainingOps
#24725
Conversation
| @nowarn("msg=ChainingSyntax will be removed in the future") | ||
| object chaining extends ChainingSyntax: | ||
| extension[A](x: A) | ||
| inline def tap(inline f: A => Unit): x.type = { f(x); x } |
There was a problem hiding this comment.
The signature here differs from the one we used to have in scala.util.ChainingOps. First, we return a more precise type: x.type. Second, we do not need to have a second type variable and specify that f: A => B since we adapt the body of the lambda after the eta-expansion. This code will compile because of the adaptation for example:
def foo(x: String): String = "()"
val x: String => Unit = foo
def bar(f: String => Unit) = ()
bar(foo)
bar(x)
| f(self) | ||
| self | ||
| } | ||
| def tap[U](f: A => U): A = scala.util.chaining.tap(self)(x => f(x)) |
There was a problem hiding this comment.
| def tap[U](f: A => U): A = scala.util.chaining.tap(self)(x => f(x)) | |
| def tap[U](f: A => U): A = scala.util.chaining.tap(self)(f) |
But it is blocked by #24726
hamzaremmal
added
area:library
hamzaremmal
force-pushed
the
chaining
branch
from
c7494fb to
6aee5bd
Compare
| */ | ||
| object chaining extends ChainingSyntax | ||
| @nowarn("msg=ChainingSyntax will be removed in the future") | ||
| object chaining extends ChainingSyntax: |
There was a problem hiding this comment.
Question for me: Can we move this object to be outside the package object util?
|
This PR's communication is off. The value added by the first commit is that Even more so, the second commit adds a public method to the API. There is no world in which this should be categorized as "chore". This is the archetypical "feat" according to any such categorization. |
| @nowarn("msg=ChainingSyntax will be removed in the future") | ||
| object chaining extends ChainingSyntax: | ||
| extension[A](x: A) | ||
| inline def tap(inline f: A => Unit): x.type = { f(x); x } |
There was a problem hiding this comment.
if you don't want to break imports like import scala.util.chaining.given then you can put these in a given AnyRef:
3 participants
No description provided.